Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31549 )
Change subject: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD ......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31549/comment/4d25103f_d2cf15ac PS2, Line 2747: lchan->abis_ip.rtp_payload == RTP_PT_CSDATA
not entirely sure it's a good idea to use the RTP payload type as criteria. […]
With the current lchan struct it would only be possible to check for CSD by checking if lchan->current_ch_mode_rate.chan_mode is any of GSM48_CMODE_DATA_*. This is also just a derivative value, the information originally comes from the channel indicator (data, speech, signalling) in the BSSAP assignment request.
I've added a patch to store the channel indicator in the struct, and used it here. -> https://gerrit.osmocom.org/c/osmo-bsc/+/31622/1