dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41251?usp=email )

Change subject: pySim-shell: update help strings for chv command parameter --pin-nr ......................................................................

pySim-shell: update help strings for chv command parameter --pin-nr

The --pin-nr is a decimal parameter that specifies which PIN (or CHV) to reference. The exact numbers are specified in ETSI TS 102.221, Table 9.3.

Unfortunately the enumeration of the PIN numbers is not very intuitive. At the moment the help suggests 1 to reference PIN1, and 2 to reference PIN2. The value for PIN1 is correct, but for PIN2, the value should be 129.

Change-Id: I0b58c402d95cbc4fe690e6edb214829d463e9f2c --- M pySim-shell.py 1 file changed, 10 insertions(+), 5 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/51/41251/1

diff --git a/pySim-shell.py b/pySim-shell.py index 977666c..8513658 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -917,7 +917,8 @@

verify_chv_parser = argparse.ArgumentParser() verify_chv_parser.add_argument( - '--pin-nr', type=int, default=1, help='PIN Number, 1=PIN1, 2=PIN2 or custom value (decimal)') + '--pin-nr', type=int, default=1, + help='PIN Number, 1=PIN1, 129=PIN2 or custom value (decimal, see also ETSI TS 102.221, Table 9.3")') verify_chv_parser.add_argument('PIN', nargs='?', type=is_decimal, help='PIN code value. If none given, CSV file will be queried')

@@ -932,7 +933,8 @@

unblock_chv_parser = argparse.ArgumentParser() unblock_chv_parser.add_argument( - '--pin-nr', type=int, default=1, help='PUK Number, 1=PIN1, 2=PIN2 or custom value (decimal)') + '--pin-nr', type=int, default=1, + help='PUK Number, 1=PIN1, 129=PIN2 or custom value (decimal, see also ETSI TS 102.221, Table 9.3")') unblock_chv_parser.add_argument('PUK', nargs='?', type=is_decimal, help='PUK code value. If none given, CSV file will be queried') unblock_chv_parser.add_argument('NEWPIN', nargs='?', type=is_decimal, @@ -953,7 +955,8 @@ change_chv_parser.add_argument('PIN', nargs='?', type=is_decimal, help='PIN code value. If none given, CSV file will be queried') change_chv_parser.add_argument( - '--pin-nr', type=int, default=1, help='PUK Number, 1=PIN1, 2=PIN2 or custom value (decimal)') + '--pin-nr', type=int, default=1, + help='PUK Number, 1=PIN1, 129=PIN2 or custom value (decimal, see also ETSI TS 102.221, Table 9.3")')

@cmd2.with_argparser(change_chv_parser) def do_change_chv(self, opts): @@ -966,7 +969,8 @@

disable_chv_parser = argparse.ArgumentParser() disable_chv_parser.add_argument( - '--pin-nr', type=int, default=1, help='PIN Number, 1=PIN1, 2=PIN2 or custom value (decimal)') + '--pin-nr', type=int, default=1, + help='PIN Number, 1=PIN1, 129=PIN2 or custom value (decimal, see also ETSI TS 102.221, Table 9.3")') disable_chv_parser.add_argument('PIN', nargs='?', type=is_decimal, help='PIN code value. If none given, CSV file will be queried')

@@ -979,7 +983,8 @@

enable_chv_parser = argparse.ArgumentParser() enable_chv_parser.add_argument( - '--pin-nr', type=int, default=1, help='PIN Number, 1=PIN1, 2=PIN2 or custom value (decimal)') + '--pin-nr', type=int, default=1, + help='PIN Number, 1=PIN1, 129=PIN2 or custom value (decimal, see also ETSI TS 102.221, Table 9.3")') enable_chv_parser.add_argument('PIN', nargs='?', type=is_decimal, help='PIN code value. If none given, CSV file will be queried')