Attention is currently required from: jolly.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/31033 )
Change subject: Add L1 signals to misdn driver
......................................................................
Patch Set 3:
(1 comment)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/926eef76_6acdf81f
PS3, Line 274: mph_information_ind(line, *((int *)msg->data));
this looks weird, since you are reading an unspecified
length (int) from msgb. […]
btw, is this field little endian or big endian?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31033
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Id8b6fad9b073cf92eee92a6906bf5b57af37e2f0
Gerrit-Change-Number: 31033
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 23 Jan 2023 10:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment