Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28046 )

Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc ......................................................................

Patch Set 4:

(1 comment)

File src/osmo-bsc/nm_bb_transc_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/a90822e9_f344c66a PS4, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_bb_trx *bb_transc, bool running)

nm_ob_enable_disable instead of nm_ob_becomes_enabled_disabled? (Same for all other *_becomes_* func […]

We are not enabling it, the BSC is not enabling it. It's the BTS announcing to us that it became enabled. So the _becomes_ looks much more clear to me. The function is not enabling, it's just a shared code path to call to do some tasks when the BTS becomes enabled.