Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email )

Change subject: gsm_utils: add gprs_tlli2tmsi() ......................................................................

Patch Set 2:

(11 comments)

File src/gsm/gsm_utils.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/dda40a94_09760386?u... : PS2, Line 1029: uint32_t ptmsi = (1 << 31) | (1 << 30); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/cb4f4aef_c16baece?u... : PS2, Line 1031: switch (gprs_tlli_type(tlli)) { please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/5c969642_abb11a83?u... : PS2, Line 1032: case TLLI_LOCAL: please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/8062cc26_f9adae35?u... : PS2, Line 1033: case TLLI_FOREIGN: please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/b5a21082_135687e1?u... : PS2, Line 1034: break; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/26573cdb_85bdb329?u... : PS2, Line 1034: break; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/d4f5b9f9_c0e7aa0a?u... : PS2, Line 1036: return 0xffffffff; code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/75e2f752_6135351a?u... : PS2, Line 1036: return 0xffffffff; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/29f3c0c2_d060e37a?u... : PS2, Line 1037: } please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/eb3c3876_72f89c67?u... : PS2, Line 1039: ptmsi |= tlli; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/6dc1e5ee_66a19cab?u... : PS2, Line 1040: return ptmsi; please, no spaces at the start of a line