Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 )
Change subject: doxygen API documentation for libosmo-e1d ......................................................................
Patch Set 1:
(8 comments)
File Doxyfile.in:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/b7775b16_4eeb3c92 PS1, Line 834: # It is adviced to generate a default header using "doxygen -w html 'adviced' may be misspelled - perhaps 'advised'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/371afc2c_2248a829 PS1, Line 1488: # TAGFILES = trailing whitespace
File include/osmocom/e1d/proto.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/022b1a17_03d0da14 PS1, Line 42: * filter: intf (required), line (optional); * in: n/a; out: array of osmo_e1dp_line_info */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/2a2be65e_208b0b5b PS1, Line 112: uint16_t magic; /*< magic value (E1DP_MAGIC) */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/fe5674c4_f76a284f PS1, Line 113: uint16_t len; /*< length of message (octets) */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/d0c863b4_639f5ed3 PS1, Line 117: uint8_t line; /*< E1 line number (or E1DP_INVALID) */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/4af5cea1_f371e781 PS1, Line 118: uint8_t ts; /*< timeslot number (or E1DP_INVALID) */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-773): https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/6c7604a2_d906f15f PS1, Line 124: uint8_t n_lines; /*< number of E1 lines within this interface */ please, no space before tabs
-
Jenkins Builder