laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26815 )
Change subject: msgb: Fix -Wsign-compare warnings ......................................................................
msgb: Fix -Wsign-compare warnings
Change-Id: I4bd14bb712fb3868b55d7e79d13276b707a6cdcb --- M src/msgb.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/26815/1
diff --git a/src/msgb.c b/src/msgb.c index ccb55aa..0881a55 100644 --- a/src/msgb.c +++ b/src/msgb.c @@ -426,11 +426,11 @@ */ char *msgb_hexdump_buf(char *buf, size_t buf_len, const struct msgb *msg) { - int buf_offs = 0; + unsigned int buf_offs = 0; int nchars; const unsigned char *start = msg->data; const unsigned char *lxhs[4]; - int i; + unsigned int i;
lxhs[0] = msg->l1h; lxhs[1] = msg->l2h;
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26815 )
Change subject: msgb: Fix -Wsign-compare warnings ......................................................................
Patch Set 1: Code-Review+1
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26815 )
Change subject: msgb: Fix -Wsign-compare warnings ......................................................................
Patch Set 2: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26815 )
Change subject: msgb: Fix -Wsign-compare warnings ......................................................................
msgb: Fix -Wsign-compare warnings
Change-Id: I4bd14bb712fb3868b55d7e79d13276b707a6cdcb --- M src/msgb.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, but someone else must approve
diff --git a/src/msgb.c b/src/msgb.c index ccb55aa..0881a55 100644 --- a/src/msgb.c +++ b/src/msgb.c @@ -426,11 +426,11 @@ */ char *msgb_hexdump_buf(char *buf, size_t buf_len, const struct msgb *msg) { - int buf_offs = 0; + unsigned int buf_offs = 0; int nchars; const unsigned char *start = msg->data; const unsigned char *lxhs[4]; - int i; + unsigned int i;
lxhs[0] = msg->l1h; lxhs[1] = msg->l2h;
-
laforge -
tnt