Attention is currently required from: pespin. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... Patch Set 2: (3 comments) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/30f41571_073afd98 PS1, Line 721: cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_ro_sel_par.cell_resel_off*2); Ack https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/12882b27_aa6fe0af PS1, Line 723: cmd->reply = "OOM."; Will be removed. I copied this line from `get_bts_rf_states` I will make another PR that removes the dot from there too https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/75d10cfb_ee9a147e PS1, Line 734: bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value)/2; Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:01:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment