Attention is currently required from: pespin.
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 )
Change subject: ctrl: Add cell reselection offset control ......................................................................
Patch Set 2:
(3 comments)
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/30f41571_073afd98 PS1, Line 721: cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_ro_sel_par.cell_resel_off*2);
space between " * "
Ack
https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/12882b27_aa6fe0af PS1, Line 723: cmd->reply = "OOM.";
I think we never put a dot in replies?
Will be removed. I copied this line from `get_bts_rf_states` I will make another PR that removes the dot from there too
https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/75d10cfb_ee9a147e PS1, Line 734: bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value)/2;
space between " / "
Ack