Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 ) Change subject: library/AMR: Add API to generate encoded RTP AMR headers ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File library/AMR_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277/comment/faffefc9_d633… PS1, Line 39: bit2oct I am surprised to see this kind of code in a TTCN-3 project. The language offers us records and templates, so why not using them? I understand that this approach is quicker to implement, but still think it should be done in a TTCNic way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 Gerrit-Change-Number: 29277 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Sep 2022 19:11:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment