fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28449 )
Change subject: fix uninitialized err pointer passed to osmo_bssap_le_dec() ......................................................................
fix uninitialized err pointer passed to osmo_bssap_le_dec()
osmo_bssap_le_dec() dereferences value of the given pointer and checks it against NULL. The caller must always initialize it.
Change-Id: Idb0e6565e362ce383c833d6bfec4fb39d2985a6b Fixes: CID#272982, CID#272944 --- M src/osmo-bsc/lb.c M src/osmo-bsc/lcs_loc_req.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 7c35fa2..276b0a1 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -100,7 +100,7 @@ { struct osmo_ss7_instance *ss7; struct bssap_le_pdu bssap_le; - struct osmo_bssap_le_err *err; + struct osmo_bssap_le_err *err = NULL; struct rate_ctr_group *ctrg = bsc_gsmnet->smlc->ctrs;
ss7 = osmo_sccp_get_ss7(osmo_sccp_get_sccp(scu)); diff --git a/src/osmo-bsc/lcs_loc_req.c b/src/osmo-bsc/lcs_loc_req.c index a658da8..d53f2ab 100644 --- a/src/osmo-bsc/lcs_loc_req.c +++ b/src/osmo-bsc/lcs_loc_req.c @@ -226,7 +226,7 @@ { struct lcs_loc_req *lcs_loc_req = conn->lcs.loc_req; struct bssap_le_pdu bssap_le; - struct osmo_bssap_le_err *err; + struct osmo_bssap_le_err *err = NULL; struct rate_ctr_group *ctrg = bsc_gsmnet->smlc->ctrs;
if (!lcs_loc_req) {
-
fixeria