[M] Change in libosmo-sigtran[master]: Allow configuring local ASP Identifier - gerrit-log

12 Feb 2026


      Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email )
Change subject: Allow configuring local ASP Identifier
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115/comment/3eeac061_14c38f... :
PS1, Line 465: id64
Change it to id or asp_id?
Maybe bike-shedding, but the only relation to 64 is that the function takes an int64_t. Even id32 would make more sense to show that it only holds values in that range.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ib94d542f940e13d5c007bc3319e7dde65cf81f12
Gerrit-Change-Number: 42115
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 12 Feb 2026 15:31:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes