laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27819 ) Change subject: Fix compile errors on #warning with '-Wall' on gcc-11.2 ...................................................................... Fix compile errors on #warning with '-Wall' on gcc-11.2 pcu_sock.c: In function ‘pcu_tx_info_ind’: pcu_sock.c:197:2: error: #warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs" [-Werror=cpp] 197 | #warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs" | ^~~~~~~ pcu_sock.c:199:2: error: #warning "isn't ul_tbf_ext wrong?: * 10 and no ntohs" [-Werror=cpp] 199 | #warning "isn't ul_tbf_ext wrong?: * 10 and no ntohs" | ^~~~~~~ they made it here from osmo-bts.git (b4999b60d48bcbb5aa575973d068e07ab672e095 states that the PCUIF support was copied from there). The gitlog shows that these warnings were added in 744f745d7a508605254afa8f78412ad410d153b0 by jolly (in 2012!) together with the PCUIF support, and before c1368d4ebe49f8e01f1f5fff3bc3583cb5960c1d these warnings were in German: "ist dl_tbf_ext nicht falsch?" As nobody has bothered for the past ten years, degrade them to comments. Change-Id: I9ef7e18f56aa86b48f0ffeec58406260736170f3 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index d6dd9a7..45ff835 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -194,9 +194,9 @@ if (rlcc->cs_mask & (1 << GPRS_MCS9)) info_ind->flags |= PCU_IF_FLAG_MCS9; } -#warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs" + /* TODO: isn't dl_tbf_ext wrong?: * 10 and no ntohs */ info_ind->dl_tbf_ext = rlcc->parameter[T_DL_TBF_EXT]; -#warning "isn't ul_tbf_ext wrong?: * 10 and no ntohs" + /* TODO: isn't ul_tbf_ext wrong?: * 10 and no ntohs */ info_ind->ul_tbf_ext = rlcc->parameter[T_UL_TBF_EXT]; info_ind->initial_cs = rlcc->initial_cs; info_ind->initial_mcs = rlcc->initial_mcs; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ef7e18f56aa86b48f0ffeec58406260736170f3 Gerrit-Change-Number: 27819 Gerrit-PatchSet: 2 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged