laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36577?usp=email )

Change subject: xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted' ......................................................................

xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted'

The event case handling (ignore it) was added in a commit some time ago, but it forgot to add it to the allstate_event_mask in the xua_fsm (it was added only in the ipa_fsm, which is the one using it).

This bug should in theory be harmless since the only code dispatching the signal is not checking the return code of osmo_fsm_inst_dispatch().

Related: SYS#5914 Fixes: 57444690212b1576eaf0a7156448ba2d27c59050 Change-Id: Iaead46bbc40b923763bc3dbe4d24d8952822de4a --- M src/xua_asp_fsm.c 1 file changed, 20 insertions(+), 1 deletion(-)

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index fadcde9..97391bb 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -769,7 +769,8 @@ .allstate_event_mask = S(XUA_ASP_E_SCTP_COMM_DOWN_IND) | S(XUA_ASP_E_SCTP_RESTART_IND) | S(XUA_ASP_E_ASPSM_BEAT) | - S(XUA_ASP_E_ASPSM_BEAT_ACK), + S(XUA_ASP_E_ASPSM_BEAT_ACK) | + S(XUA_ASP_E_AS_ASSIGNED), .allstate_action = xua_asp_allstate, .cleanup = xua_asp_fsm_cleanup, };