fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email ) Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN ...................................................................... smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index a2832d3..d48cd79 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -2,7 +2,7 @@ #include <osmocom/msc/gsm_data.h> -/* Length limits according to SMPP 3.4 spec including NUL-byte: */ +/* Length limits according to SMPP 3.4 spec excluding NUL-byte: */ #define SMPP_SYS_ID_LEN 15 #define SMPP_PASSWD_LEN 8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc Gerrit-Change-Number: 37237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged