Attention is currently required from: msuraev.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29679 )
Change subject: LAPD: log unknown format value
......................................................................
Patch Set 1:
(1 comment)
File src/gsm/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/29679/comment/08eec8b2_76ccd84b
PS1, Line 1711: %u
I suggest printing as hex instead: 0x%02x.
Actually, this is not really needed given that there's only three valid values
in 'enum lapd_format', and here we're most likely hitting LAPD_FORM_UKN.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29679
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9efd433ed128ae1d9df45591b1a93e10f8a3372c
Gerrit-Change-Number: 29679
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Oct 2022 07:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment