Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28874 )
Change subject: trxcon: allow populating global SACCH cache via L1CTL ......................................................................
Patch Set 2:
(2 comments)
File src/host/trxcon/src/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28874/comment/997a23e7_91a1e721 PS1, Line 655: if (!traffic && req.link_id == 0x40)
can you describe this 0x40? I'm sure we may have some sort of defines for it?
I added a comment: 0x40 means SACCH. Unfortunately there is no macro in libosmocore...
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28874/comment/1045c3cc_b52c168d PS1, Line 90: LOGPFSML(fi, LOGL_ERROR, "Unexpected link_id=%u\n", req->link_id);
probably want to print as hex
Done
-
fixeria