Attention is currently required from: pespin.

View Change

2 comments:

• File src/host/trxcon/src/l1ctl.c:

  • Patch Set #1, Line 655: if (!traffic && req.link_id == 0x40)

    can you describe this 0x40? I'm sure we may have some sort of defines for it?

    I added a comment: 0x40 means SACCH. Unfortunately there is no macro in libosmocore...

• File src/host/trxcon/src/trxcon_fsm.c:

  • Patch Set #1, Line 90: LOGPFSML(fi, LOGL_ERROR, "Unexpected link_id=%u\n", req->link_id);

    probably want to print as hex

    Done

To view, visit change 28874. To unsubscribe, or for help writing mail filters, visit settings.