Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email )
Change subject: Add multiple messages buffers to io_uring read operations
......................................................................
Patch Set 7:
(3 comments)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/1b36d4d7_595e9d66?… :
PS7, Line 149: /* Set IO vectors and allocate additional read buffers.
I have the feeling all this code may need to go inside iofd_msghdr_alloc(), as well as the
first iofd_msgb_alloc() above.
https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/68bb6e03_5a8b6e12?… :
PS7, Line 154: msghdr->msg[idx] = iofd_msgb_alloc(iofd);
OSMO_ASSERT(msghdr->msg[idx])
https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/44a55283_344b29c1?… :
PS7, Line 208: int idx;
this can be an unsigned int afaict.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce
Gerrit-Change-Number: 40492
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 28 Jul 2025 10:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No