Attention is currently required from: laforge.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/35455?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Fix TLV_IE_Collection.from_tlv in certain situations ......................................................................
Fix TLV_IE_Collection.from_tlv in certain situations
The existing code used to produce an empty output in situations where a TLV_IE_Collection would be parsed from a single TLV only with some additional trailing padding:
from pySim.utils import h2b from pySim.ts_31_102 import EF_CSGT t = EF_CSGT.Csgt_TLV_Collection() t.from_tlv(h2b('8906810300666f6fff'))
[TextCsgType(foo)]
t.to_dict()
[]
This was caused by an early return (actually returning the decoded result) but *without updating self.children*.
Change-Id: I1c84ccf698c6ff7e7f14242f9aaf7d15ac2239f4 --- M pySim/tlv.py 1 file changed, 25 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/35455/2
-
laforge