Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email )
Change subject: Add environment variable to set io_uring size
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/2136ce09_fe2b3fda?… :
PS2, Line 111: rc = osmo_str_to_int(&g_io_uring_size, env, 10, 1, 32768);
I wonder where 32768 comes from :D
https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/360a1e2e_952260c3?… :
PS2, Line 116: if ((g_io_uring_size & (g_io_uring_size - 1))) {
if (g_io_uring_size & 0x01)
https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/c8e2b206_2c594a91?… :
PS2, Line 117: fprintf(stderr, "Error: Initial io_uring size must be a positive
power of two.\n");
Is this really needed as per io_uring API?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484
Gerrit-Change-Number: 40782
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 01 Aug 2025 11:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes