Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/32206
)
Change subject: msc_mgw_setup: use mgcp_client_pool_empty()
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-msc/msc_main.c:
https://gerrit.osmocom.org/c/osmo-msc/+/32206/comment/d58c8d84_f0effe15
PS2, Line 565: if (pool_members_initalized) {
Can you perhaps now change this to have the error as
early termination? it's way clearer imho since […]
agreed, this is more
readable. thanks!
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/32206
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3
Gerrit-Change-Number: 32206
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Apr 2023 14:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment