Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27919 )
Change subject: abis_nm: don't compare assumed/reported features ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27919/comment/c73fa4ff_aa5060e9 PS1, Line 603: if (i >= _NUM_BTS_FEAT) { I'd rather put this check before the osmo_bts_has_feature() one, because otherwise you'll probably never print the LOGPMO below for "unknwon features", since it will actually most probably be osmo_bts_has_feature(&bts->features, i) == false.