Attention is currently required from: pespin, fixeria.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 )

Change subject: Move out of alloc_algo code modifying the data model ......................................................................

Patch Set 7: Code-Review+1

(6 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/047dab99_f749e88e PS7, Line 10: abck back

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/6697760b_68eb53b5 PS7, Line 15: responisble responsible

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/0a5dab09_28a741d3 PS7, Line 16: allocat allocate

Patchset:

PS7: LGTM, just some cosmetics

File src/alloc_algo.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/3a227ae0_6648da3d PS7, Line 310: * \param[in] req Contains all the requested params add res to the description here? same 2x below

File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/798a6dae_5e31944a PS7, Line 588: missing " and "