fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34759?usp=email ) Change subject: mobile: mncc_call(): make *number argument const ...................................................................... mobile: mncc_call(): make *number argument const Change-Id: I4558ce1313b8e9aadd73474a6514c136aa512de3 --- M src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h M src/host/layer23/src/mobile/mnccms.c M src/host/layer23/src/mobile/vty_interface.c 3 files changed, 13 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h b/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h index 49ce1a4..705c681 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h +++ b/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h @@ -1,6 +1,6 @@ #pragma once -int mncc_call(struct osmocom_ms *ms, char *number); +int mncc_call(struct osmocom_ms *ms, const char *number); int mncc_hangup(struct osmocom_ms *ms); int mncc_answer(struct osmocom_ms *ms); int mncc_hold(struct osmocom_ms *ms); diff --git a/src/host/layer23/src/mobile/mnccms.c b/src/host/layer23/src/mobile/mnccms.c index 6add5d5..a068ee9 100644 --- a/src/host/layer23/src/mobile/mnccms.c +++ b/src/host/layer23/src/mobile/mnccms.c @@ -533,7 +533,7 @@ return 0; } -int mncc_call(struct osmocom_ms *ms, char *number) +int mncc_call(struct osmocom_ms *ms, const char *number) { struct gsm_call *call; struct gsm_mncc setup; diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 2a09608..ea355b3 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -497,7 +497,7 @@ struct osmocom_ms *ms; struct gsm_settings *set; struct gsm_settings_abbrev *abbrev; - char *number; + const char *number; ms = l23_vty_get_ms(argv[0], vty); if (!ms) @@ -510,7 +510,7 @@ return CMD_WARNING; } - number = (char *)argv[1]; + number = argv[1]; if (!strcmp(number, "emergency")) mncc_call(ms, number); else if (!strcmp(number, "answer")) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4558ce1313b8e9aadd73474a6514c136aa512de3 Gerrit-Change-Number: 34759 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged