Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 6: (3 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/c06f4857_858a89db PS6, Line 704: if (msgb_length(msg) == GSM_HR_BYTES + sizeof(struct rtp_hdr)) { Not criticial, but you could even have a switch case here: switch(msgb_length(msg)) https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/354e9fd5_7e1a58ed PS6, Line 705: /* Abort early in case the input format (TS 101318) already Abort sounds like failing here. "Do nothing in case" would be far more informative imho. https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/b6c2fe05_b254f68a PS6, Line 1250: } else if ((rtp_end->rfc5993_hr_convert || Sounds like we want to have some function and put all this conditions together? It starts to be difficult to read it, and this is quite a main data code path. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 15:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment