Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27016 ) Change subject: Allow configuration of interfaces/lines via VTY ...................................................................... Patch Set 3: Code-Review+1 (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/5a624397_49644026 PS3, Line 15: those E1 lines with VTY configuration opened. are opened / will be opened. File src/e1d.h: https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/1b175e02_cac6b6bb PS3, Line 181: e1d_find_intf_by_serial(struct e1_daemon *e1d, const char *serial_str); by_usb_serial? File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/99383540_6c9f8730 PS3, Line 561: /* try to find the matching interface config in the */ in the what? https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/06aaae59_344aa651 PS3, Line 564: LOGP(DE1D, LOGL_INFO, "configuration for icE1usb serial '%s' found\n", serial_str); start with caps https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/8215e96e_3247cdb4 PS3, Line 567: LOGP(DE1D, LOGL_ERROR, "new device with serial '%s', but E1 interface %u busy\n", start with caps https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/a7a159ba_8ca5ab08 PS3, Line 576: LOGP(DE1D, LOGL_NOTICE, "no configuration for icE1usb serial '%s' found, " start with caps -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I89b57b688b68901f87d9683ab9294772ee747d77 Gerrit-Change-Number: 27016 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 31 Jan 2022 16:42:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment