Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31091 ) Change subject: SI13: drop meaningless error check ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31091/comment/0be1420c_e89c06fc PS1, Line 9: always return positive integer I disagree - writing code against some potentially-could-be API which we do not even have plans introducing instead of writing it against current documented API is meaningless. It also adds unnecessary confusion for the reader - especially given that other uses of such functions like osmo_gsm48_rest_octets_si1_encode() do not have this kind of useless checks. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b Gerrit-Change-Number: 31091 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment