Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31091 )

Change subject: SI13: drop meaningless error check ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/31091/comment/0be1420c_e89c06fc PS1, Line 9: always return positive integer

But it still returns a signed integer, and some day somebody may add an additional checks making it […]

I disagree - writing code against some potentially-could-be API which we do not even have plans introducing instead of writing it against current documented API is meaningless. It also adds unnecessary confusion for the reader - especially given that other uses of such functions like osmo_gsm48_rest_octets_si1_encode() do not have this kind of useless checks.