laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26709 ) Change subject: Use the error counters for remote alarm + remote CRC error ...................................................................... Use the error counters for remote alarm + remote CRC error Some time ago we added various error counters, but for two of them we missed to actually ever increment them at all. Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a --- M src/mux_demux.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/mux_demux.c b/src/mux_demux.c index b0a9cf2..a588829 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -359,8 +359,10 @@ /* A bit is present in each odd frame */ if (frame_nr % 2) { - if (frame[0] & 0x20) + if (frame[0] & 0x20) { line->ts0.cur_errmask |= E1L_TS0_RX_ALARM; + line_ctr_add(line, LINE_CTR_RX_REMOTE_A, 1); + } } /* E bits are present in frame 13 + 15 */ @@ -368,8 +370,10 @@ line->ts0.e_bits = frame[0] & 0x80 ? 2 : 0; if (frame_nr == 15) { line->ts0.e_bits |= frame[0] & 0x80 ? 1 : 0; - if (line->ts0.e_bits != 3) + if (line->ts0.e_bits != 3) { line->ts0.cur_errmask |= E1L_TS0_RX_CRC4_ERR; + line_ctr_add(line, LINE_CTR_RX_REMOTE_E, 1); + } } /* cur_errmask is being cleared once per second via line->ts0.timer */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a Gerrit-Change-Number: 26709 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged