Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

Attention is currently required from: fixeria. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... Patch Set 2: (2 comments) File src/libmsc/transaction.c: https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/8e6a083b_e064df77 PS1, Line 165: %sfor Actually done intentionally, because osmo_hexdump() seems to add a space at the end. If I add the "missing" space then the log line will contain two spaces. https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/4fe15bb1_ac4f8812 PS1, Line 165: 0x%x I'm guessing you mean 0x%04x, although I don't understand why. It's 4 octets anyway, no? - the logging macro often logging callref uses: ..... LOGP(subsys, level, \ "trans(%s %s callref-0x%x tid-%u%s) " fmt, \ .... But I trust your request, I hope I have it right. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 02:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment