Change in libosmo-abis[master]: Add L1 signals to misdn driver

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31033 ) Change subject: Add L1 signals to misdn driver ...................................................................... Patch Set 3: (3 comments) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/e0994732_914d1617 PS3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n"); did you think about using a value_string to print the type? https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/dbe1f250_4e4d3926 PS3, Line 274: mph_information_ind(line, *((int *)msg->data)); this looks weird, since you are reading an unspecified length (int) from msgb. Maybe uint32_t? https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/b91ef3fc_75f610d4 PS3, Line 636: mph_information_ind(line, *((int *)msg->data)); same. uint32_t? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Id8b6fad9b073cf92eee92a6906bf5b57af37e2f0 Gerrit-Change-Number: 31033 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 23 Jan 2023 10:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment