Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email )
Change subject: Adopt iu_client from osmo-iuh ......................................................................
Patch Set 1:
(15 comments)
File include/osmocom/sgsn/iu_client.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/cac97608_81c710b6?usp... : PS1, Line 70: typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id, do not add new typedefs
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/bbb47fa4_e85b0453?usp... : PS1, Line 70: typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id, space prohibited after that '*' (ctx:BxW)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/44836e91_67482f63?usp... : PS1, Line 70: typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id, space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/dd039823_5be72d30?usp... : PS1, Line 73: typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, do not add new typedefs
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/a227921d_4f1ab95d?usp... : PS1, Line 73: typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, space prohibited after that '*' (ctx:BxW)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/6794df86_bf12acda?usp... : PS1, Line 73: typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/69b3e3e9_6343b807?usp... : PS1, Line 76: typedef int (* ranap_iu_rab_ass_resp_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, uint8_t rab_id, space prohibited after that '*' (ctx:BxW)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/e104cdc5_fc2dc166?usp... : PS1, Line 76: typedef int (* ranap_iu_rab_ass_resp_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, uint8_t rab_id, space prohibited before that close parenthesis ')'
File src/sgsn/iu_client.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/52a3f888_d4fecf0d?usp... : PS1, Line 399: msg = ranap_new_msg_sec_mod_cmd(vec->ik, send_ck? vec->ck : NULL, spaces required around that '?' (ctx:VxW)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/ed4c6631_c206cb83?usp... : PS1, Line 443: -- not used at present -- please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/ccde724d_c7a57127?usp... : PS1, Line 443: -- not used at present -- space prohibited after that '--' (ctx:ExW)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/5054efe2_390b3179?usp... : PS1, Line 443: -- not used at present -- space prohibited before that '--' (ctx:WxE)
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/0eff36f1_faa4e5db?usp... : PS1, Line 527: if (ies->presenceMask & DIRECTTRANSFERIES_RANAP_RAC_PRESENT) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/bd1ae5ee_fbe47a3a?usp... : PS1, Line 669: else else should follow close brace '}'
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/40812/comment/cf22a764_f5af726d?usp... : PS1, Line 874: LOGPIUC(log_level, ", for %s %08x\n", is_ps? "PTMSI" : "TMSI", *tmsi_or_ptmsi); spaces required around that '?' (ctx:VxW)