View Change

15 comments:

• File include/osmocom/sgsn/iu_client.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 70: typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id,

    do not add new typedefs

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 70: typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id,

    space prohibited after that '*' (ctx:BxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 70: typedef int (* ranap_iu_recv_cb_t )(struct msgb *msg, struct gprs_ra_id *ra_id,

    space prohibited before that close parenthesis ')'

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 73: typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx,

    do not add new typedefs

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 73: typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx,

    space prohibited after that '*' (ctx:BxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 73: typedef int (* ranap_iu_event_cb_t )(struct ranap_ue_conn_ctx *ue_ctx,

    space prohibited before that close parenthesis ')'

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 76: typedef int (* ranap_iu_rab_ass_resp_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, uint8_t rab_id,

    space prohibited after that '*' (ctx:BxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 76: typedef int (* ranap_iu_rab_ass_resp_cb_t )(struct ranap_ue_conn_ctx *ue_ctx, uint8_t rab_id,

    space prohibited before that close parenthesis ')'

• File src/sgsn/iu_client.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 399: msg = ranap_new_msg_sec_mod_cmd(vec->ik, send_ck? vec->ck : NULL,

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 443: -- not used at present --

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 443: -- not used at present --

    space prohibited after that '--' (ctx:ExW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 443: -- not used at present --

    space prohibited before that '--' (ctx:WxE)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 527: if (ies->presenceMask & DIRECTTRANSFERIES_RANAP_RAC_PRESENT) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 669: else

    else should follow close brace '}'

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 874: LOGPIUC(log_level, ", for %s %08x\n", is_ps? "PTMSI" : "TMSI", *tmsi_or_ptmsi);

    spaces required around that '?' (ctx:VxW)

To view, visit change 40812. To unsubscribe, or for help writing mail filters, visit settings.