Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 )
Change subject: Add initial SBc-AP support to osmo-cbc ......................................................................
Patch Set 10:
(4 comments)
File include/osmocom/cbc/cbc_data.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/56c05280_a0b510eb PS10, Line 23: CBC_PEER_PROTO_SBcAP cosmetic: missing comma
File include/osmocom/cbc/internal.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/a6eff4be_d01902c2 PS10, Line 30: enum sbcap_server_event { So we have the same set of events as in enum cbsp_server_event. Can both FSMs simply use a single unified set of events?
File src/cbc_data.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/9947dc6a_f858f547 PS10, Line 104: ws, 'unsigned int i' could be added here (scoped variable)
File src/smscb_peer_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/520e6770_6221b929 PS10, Line 483: cosmetic: there should be no space here