Attention is currently required from: neels, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ......................................................................
Patch Set 19:
(5 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/ca552eee_6f3870ed PS18, Line 7: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
The commit message contains nothing about bumping the PCUIF version. […]
Done
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/7293ca45_e074be67 PS18, Line 43: PCU_IF_SAPI_PCH_DT
Didn't we agree that in the new PCUIF version there will be only one way to send DL blocks over PCH […]
Yes, its a bit ugly, but we need to stay backwards compatible at least until we updated OsmoBTS as well. I will do this as soon as possible.
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/db32aad3_21158176 PS18, Line 273: is send
typo: is sent
Done
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/c0413f83_80134689 PS17, Line 280: uint8_t pgroup[3];
Wait a minute, I am confused by this field. […]
Its indeed much simpler. Actually the paging group is only one byte in reality. I have checked this back with the spec. I don't know why we use uint16_t or even unsigned int in other places. This probably has historical reasons.
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/2b7bfb49_4487656e PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
Here is the BTS side patch: https://gerrit.osmocom.org/c/osmo-bts/+/31600 [WIP]. […]
Here is the related ticket: https://osmocom.org/issues/5927