Attention is currently required from: neels, fixeria, pespin.

View Change

5 comments:

• Commit Message:

  • Patch Set #18, Line 7: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

    The commit message contains nothing about bumping the PCUIF version. […]

    Done

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #18, Line 43: PCU_IF_SAPI_PCH_DT

    Didn't we agree that in the new PCUIF version there will be only one way to send DL blocks over PCH […]

    Yes, its a bit ugly, but we need to stay backwards compatible at least until we updated OsmoBTS as well. I will do this as soon as possible.

  • Patch Set #18, Line 273: is send

    typo: is sent

    Done

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #17, Line 280: uint8_t pgroup[3];

    Wait a minute, I am confused by this field. […]

    Its indeed much simpler. Actually the paging group is only one byte in reality. I have checked this back with the spec. I don't know why we use uint16_t or even unsigned int in other places. This probably has historical reasons.

• File src/bts.cpp:

  • Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));

    Here is the BTS side patch: https://gerrit.osmocom.org/c/osmo-bts/+/31600 [WIP]. […]

    Here is the related ticket: https://osmocom.org/issues/5927

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.