Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/a970b306_5131dfff PS5, Line 1105: #ifdef ENABLE_ERICSSON_RBS Agreeing with Pau here, maybe make the BTS type configurable somehow? Or even better: make BSC/BTS indicate whether it supports PCU_IF_SAPI_PCH_DT via the INFO.ind and use it only if supported. File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/21cb9014_60c16a64 PS5, Line 320: data[sizeof(tlli) + (PAGING_GROUP_LEN - 1 - i)] Maybe add a packed struct to the pcuif_proto.h rather than having offsets here and there? struct { uint32_t tlli; uint8_t pgroup[3]; uint8_t data_len; /* is this correct? */ uint8_t data[0]; } __attribute__((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 18:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment