Attention is currently required from: pespin, dexter.

Patch set 5:Code-Review -1

View Change

2 comments:

• File src/bts.cpp:

  • Patch Set #5, Line 1105: #ifdef ENABLE_ERICSSON_RBS

    Now here comes another rant. Imagine you have a network with both osmo-bts and ericcsson BTS. […]

    Agreeing with Pau here, maybe make the BTS type configurable somehow? Or even better: make BSC/BTS indicate whether it supports PCU_IF_SAPI_PCH_DT via the INFO.ind and use it only if supported.

• File src/pcu_l1_if.cpp:

  • Patch Set #5, Line 320: data[sizeof(tlli) + (PAGING_GROUP_LEN - 1 - i)]

    Maybe add a packed struct to the pcuif_proto.h rather than having offsets here and there?

      struct {
        uint32_t tlli;
        uint8_t pgroup[3];
        uint8_t data_len; /* is this correct? */
        uint8_t data[0];
      } __attribute__((packed));

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.