Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.
clufn has posted comments on this change by clufn. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support
......................................................................
Patch Set 9:
(7 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/d025c0f0_9fd2…
:
PS8, Line 66: A:8,
`A` is not used, so please do `_:8`.
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/5029bb43_d6ae…
:
PS8, Line 66: when is_binary(Rest)
Can this condition ever be false? `Rest/binary` is a
`binary` by definition...
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/80bb7d8c_10a2…
:
PS8, Line 69: get_6_from_bin
This can be done in a less verbose way: […]
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/f6e343de_2e5f…
:
PS8, Line 72: get_v4v6
``` […]
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/1e7ba4c7_ee9f…
:
PS8, Line 75: when is_binary(Rest)
Likewise here: […]
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/19972a64_3e3a…
:
PS8, Line 77: get_6_from_v4v6
``` […]
Done
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/822aef8e_0451…
:
PS8, Line 147: #{pdp_type_org => 1,
: pdp_type_nr => ?GTP_PDP_ADDR_TYPE_NR_IPv4v6,
:
Please fix formatting here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 9
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 08 May 2025 18:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>