Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.

View Change

7 comments:

• File src/conv.erl:

  • Patch Set #8, Line 66: A:8,

    `A` is not used, so please do `_:8`.

    Done

  • Patch Set #8, Line 66: when is_binary(Rest)

    Can this condition ever be false? `Rest/binary` is a `binary` by definition...

    Done

  • Patch Set #8, Line 69: get_6_from_bin

    This can be done in a less verbose way: […]

    Done

  • Patch Set #8, Line 72: get_v4v6

    ``` […]

    Done

  • Patch Set #8, Line 75: when is_binary(Rest)

    Likewise here: […]

    Done

  • Patch Set #8, Line 77: get_6_from_v4v6

    ``` […]

    Done

  • Patch Set #8, Line 147:

    #{pdp_type_org => 1,
            pdp_type_nr => ?GTP_PDP_ADDR_TYPE_NR_IPv4v6,
      
    

    Please fix formatting here.

    Done

To view, visit change 40255. To unsubscribe, or for help writing mail filters, visit settings.