Attention is currently required from: lynxis lazus.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email )
Change subject: firmware: allow to change the sim presence pin polarity ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/8761dd5c_d1434f16 PS6, Line 12: n "Even though" ?
Patchset:
PS6: rather fix the "prensence" typo in the symbol name before merging (see in-line comment). otherwise looks sane, though I don't know this code.
File firmware/libcommon/include/simtrace.h:
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/b99831f2_2b2a50c4 PS6, Line 128: prensence typo in the name, should be "_presence_" (same below)
File firmware/libcommon/include/simtrace_prot.h:
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/872ccfcf_c571d209 PS6, Line 274: is valid bit maybe "is a validity bit" or "indicates validity"?