[M] Change in simtrace2[master]: firmware: allow to change the sim presence pin polarity

Attention is currently required from: lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email ) Change subject: firmware: allow to change the sim presence pin polarity ...................................................................... Patch Set 6: Code-Review+1 (4 comments) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/8761dd5c_d1434f16 PS6, Line 12: n "Even though" ? Patchset: PS6: rather fix the "prensence" typo in the symbol name before merging (see in-line comment). otherwise looks sane, though I don't know this code. File firmware/libcommon/include/simtrace.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/b99831f2_2b2a50c4 PS6, Line 128: prensence typo in the name, should be "_presence_" (same below) File firmware/libcommon/include/simtrace_prot.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/872ccfcf_c571d209 PS6, Line 274: is valid bit maybe "is a validity bit" or "indicates validity"? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456 Gerrit-Change-Number: 36981 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Jun 2024 01:34:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment