Attention is currently required from: lynxis lazus.

Patch set 6:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #6, Line 12: n

    "Even though" ?

• Patchset:

  • Patch Set #6:

    rather fix the "prensence" typo in the symbol name before merging (see in-line comment).
    otherwise looks sane, though I don't know this code.

• File firmware/libcommon/include/simtrace.h:

  • Patch Set #6, Line 128: prensence

    typo in the name, should be "_presence_"
    (same below)

• File firmware/libcommon/include/simtrace_prot.h:

  • Patch Set #6, Line 274: is valid bit

    maybe "is a validity bit" or "indicates validity"?

To view, visit change 36981. To unsubscribe, or for help writing mail filters, visit settings.