Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email )
Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ......................................................................
Patch Set 2:
(1 comment)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/9828ff3a_d3546e49?usp=... : PS2, Line 1000: if (bearer_cap.transfer == GSM48_BCAP_ITCAP_SPEECH) : bearer_cap = (struct gsm_mncc_bearer_cap){ : .transfer = GSM48_BCAP_ITCAP_SPEECH, : .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ : .speech_ver = { -1 }, : }; : I suggest to avoid copying the given `struct gsm_mncc_bearer_cap`:
```suggestion static const struct gsm_mncc_bearer_cap bcap_speech = { .transfer = GSM48_BCAP_ITCAP_SPEECH, .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ .speech_ver = { -1 }, };
if (bearer_cap->transfer == GSM48_BCAP_ITCAP_SPEECH) bearer_cap = &bcap_speech; ```