Attention is currently required from: osmith.

View Change

1 comment:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #2, Line 1000:

    	if (bearer_cap.transfer == GSM48_BCAP_ITCAP_SPEECH)
    		bearer_cap = (struct gsm_mncc_bearer_cap){
    			.transfer = GSM48_BCAP_ITCAP_SPEECH,
    			.radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */
    			.speech_ver = { -1 },
    		};
    
    

    I suggest to avoid copying the given `struct gsm_mncc_bearer_cap`:

    ```suggestion
    	static const struct gsm_mncc_bearer_cap bcap_speech = {
    		.transfer = GSM48_BCAP_ITCAP_SPEECH,
    		.radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */
    		.speech_ver = { -1 },
    	};

    	if (bearer_cap->transfer == GSM48_BCAP_ITCAP_SPEECH)
    		bearer_cap = &bcap_speech;
    ```

To view, visit change 41043. To unsubscribe, or for help writing mail filters, visit settings.