15 Apr
2024
15 Apr
'24
5:17 p.m.
Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email )
Change subject: msc: f_expect_paging(): fix by_tmsi arg
......................................................................
Patch Set 3:
(1 comment)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455/comment/128c32d2_404c…
PS3, Line 1371: f_expect_paging_tmsi(g_pars.tmsi);
say there is a g_pars.tmsi set, but a test case wants
to explicitly expect a paging without TMSI (maybe just for failing fast on the wrong
response), then to NOT have a TMSI in the template, i have to call f_expect_paging_tmsi().
That's kind of weird, right?
I would agree if the function was called `f_expect_paging_by_tmsi()`,
but in this case the `_tmsi` just indicates presence of an additional parameter.
the RANAP part doesn't match the TMSI arguments
well, since there is no TMSI involved.
The same applies to your original patch: you call `f_expect_paging(by_tmsi := true)`, but
Iu/RANAP does not match by TMSI.
But let's get over this and just merge it, shall
we?
Ack, we can keep arguing forever...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a
Gerrit-Change-Number: 36455
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Apr 2024 15:17:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment