Attention is currently required from: neels.

View Change

1 comment:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #3, Line 1371: f_expect_paging_tmsi(g_pars.tmsi);

    say there is a g_pars.tmsi set, but a test case wants to explicitly expect a paging without TMSI (maybe just for failing fast on the wrong response), then to NOT have a TMSI in the template, i have to call f_expect_paging_tmsi(). That's kind of weird, right?

    I would agree if the function was called `f_expect_paging_by_tmsi()`,
    but in this case the `_tmsi` just indicates presence of an additional parameter.

    the RANAP part doesn't match the TMSI arguments well, since there is no TMSI involved.

    The same applies to your original patch: you call `f_expect_paging(by_tmsi := true)`, but Iu/RANAP does not match by TMSI.

    But let's get over this and just merge it, shall we?

    Ack, we can keep arguing forever...

To view, visit change 36455. To unsubscribe, or for help writing mail filters, visit settings.