Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27972 )
Change subject: abis_nm: add bts model features to reported ones ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27972/comment/423166a1_f236477f PS1, Line 620: for (i = 0; i < _NUM_BTS_FEAT; i++) { if bts->type == GSM_BTS_TYPE_NANOBTS
https://gerrit.osmocom.org/c/osmo-bsc/+/27972/comment/7583ebfc_a358a7ae PS1, Line 621: if (!osmo_bts_has_feature(&bts->model->features, i) || /* intentional check against bts model */ This early continue is difficult to understand, I had to turn ir around to understand it. IMHO it's a lote more clearer:
if (osmo_bts_has_feature(&bts->model->features, i) && !osmo_bts_has_feature(&bts->features, i)) { LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: feature '%s' is assumed to be supported\n", osmo_bts_features_name(i)); osmo_bts_set_feature(&bts->features, i); }