Attention is currently required from: osmith.

View Change

2 comments:

• File src/osmo-bsc/abis_nm.c:

  • Patch Set #1, Line 620: for (i = 0; i < _NUM_BTS_FEAT; i++) {

    if bts->type == GSM_BTS_TYPE_NANOBTS

  • Patch Set #1, Line 621: if (!osmo_bts_has_feature(&bts->model->features, i) || /* intentional check against bts model */

    This early continue is difficult to understand, I had to turn ir around to understand it. IMHO it's a lote more clearer:

    if (osmo_bts_has_feature(&bts->model->features, i) &&
        !osmo_bts_has_feature(&bts->features, i)) {
        LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: feature '%s' is assumed to be supported\n", osmo_bts_features_name(i));
        osmo_bts_set_feature(&bts->features, i);
    }

To view, visit change 27972. To unsubscribe, or for help writing mail filters, visit settings.