Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP) ......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/bbc2e07f_d7e2e855 PS4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp);
Is this needed by any app right now? […]
It's not specific about this API, but in general when having developed stuff for libosmo-sccp I have the feeling a lot of stuff ended up being public which wasn't really needed, and that made making improvements later on more difficult.
So in general in this lib my opinion is: keep it private until it is needed by someone else. Late on Moving private -> public is easy. Moving public -> private is not.