Attention is currently required from: fixeria, jolly, laforge.

View Change

1 comment:

• File include/osmocom/sigtran/osmo_ss7.h:

  • Patch Set #4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp);

    > Is this needed by any app right now? […]

    It's not specific about this API, but in general when having developed stuff for libosmo-sccp I have the feeling a lot of stuff ended up being public which wasn't really needed, and that made making improvements later on more difficult.

    So in general in this lib my opinion is: keep it private until it is needed by someone else.
    Late on Moving private -> public is easy. Moving public -> private is not.

To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.