Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/29788 )
Change subject: Add BTS setup ramping to prevent BSC overloading
......................................................................
Patch Set 15:
(4 comments)
File src/osmo-bsc/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/2308ff53_70d75df4
PS1, Line 345: case NM_EV_RAMP_GO:
I'm not really following you. […]
In the
past yes, I've changed the code so it couldn't happen again. but i'm not sure
if it's better this way.
File src/osmo-bsc/nm_bts_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/c15dc3c3_d580a937
PS1, Line 92: struct gsm_bts *bts,
Actually, I see now that you are changing the
formatting of this line for now reason, so leave it wa […]
Done
File src/osmo-bsc/nm_bts_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/04156218_80b72584
PS4, Line 401: .ignore_invalid_events =
As mentioned I don't think this is needed. We can
discuss it further.
i've replaced it.
File src/osmo-bsc/nm_channel_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/2c2ba3f9_14fdc07d
PS10, Line 224: configure_loop(ts, &ts->mo.nm_state, false);
this is wrong, it should be "true".
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29788
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d
Gerrit-Change-Number: 29788
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Nov 2022 15:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment